Skip to content

feat(ux): add api key visibility toggles and fix label bindings - #583

Merged
d-oit merged 1 commit into
mainfrom
jules-2823703525234624715-09a2011b
Aug 21, 2026
Merged

feat(ux): add api key visibility toggles and fix label bindings#583
d-oit merged 1 commit into
mainfrom
jules-2823703525234624715-09a2011b

Conversation

@d-oit

@d-oit d-oit commented Aug 14, 2026

Copy link
Copy Markdown
Owner

What

API-key visibility Show/Hide toggles plus accessibility fixes in the two surfaces that enter API keys (Sidebar + Settings). Rebased onto current main; stripped from the original branch: workflow SHA bumps (landed via #588), Cargo.lock churn, deny.toml edits (superseded by #593), a tsconfig.json jsx: preserve → react-jsx change (Next.js requires preserve), auto-generated next-env.d.ts drift, and unrelated web/package.json version downgrades.

  • Sidebar: per-provider Show/Hide toggle, <label htmlFor> binding
  • Settings: Show/Hide toggle, label binding, type="button" on Remove, replaces focus:outline-none with high-contrast focus-visible outlines

Note: the earlier "9 Codacy issues" report was computed against the old branch state that contained the lockfile/tsconfig/workflow noise; analysis restarts fresh on this diff.

@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel

vercel Bot commented Aug 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
do-web-doc-resolover Ready Ready Preview Aug 21, 2026 3:06pm

@codacy-production

Copy link
Copy Markdown
Contributor

Not up to standards ⛔

🔴 Issues 7 high · 2 medium

Alerts:
⚠ 9 issues (≤ 0 issues of at least minor severity)

Results:
9 new issues

Category Results
ErrorProne 2 medium
4 high
Security 3 high

View in Codacy

🟢 Metrics 14 complexity

Metric Results
Complexity 14

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@d-oit d-oit changed the title Add API key visibility toggles and improve keyboard focus accessibility feat(ux): bind settings labels and restore visible keyboard focus Aug 21, 2026
@d-oit
d-oit force-pushed the jules-2823703525234624715-09a2011b branch from 7fdb683 to de7fb07 Compare August 21, 2026 14:54
@d-oit d-oit changed the title feat(ux): bind settings labels and restore visible keyboard focus feat(ux): add api key visibility toggles and fix label bindings Aug 21, 2026
@d-oit
d-oit force-pushed the jules-2823703525234624715-09a2011b branch from de7fb07 to bd6fa89 Compare August 21, 2026 15:05
@d-oit
d-oit merged commit 2a56190 into main Aug 21, 2026
48 of 49 checks passed
@d-oit
d-oit deleted the jules-2823703525234624715-09a2011b branch August 21, 2026 15:21

d-oit commented Aug 21, 2026

Copy link
Copy Markdown
Owner Author

Codacy status note: the check-run reports action_required because it's stuck triaging the 9 findings reported against the old branch state (lockfile/tsconfig/workflow churn that this PR no longer contains). The final diff is two TSX files only; verified locally: full-repo eslint . clean, tsc --noEmit clean, and no Security-category pattern surface in the added lines. All repo-side quality gates pass: Quality Gate ✅, Lint ✅, Typecheck ✅, Unit Tests ✅, Build ✅, commitlint ✅.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant